Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: split coverage e2e #872

Merged
merged 16 commits into from
Nov 19, 2024
Merged

test: split coverage e2e #872

merged 16 commits into from
Nov 19, 2024
+666 −518

Conversation

BioPhoton
Copy link
Collaborator

This PR moves all plugin-coverage related e2e tests into a separate project and uses a new project coverage-e2e-env to maintain the static files

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024 •
edited
Loading

Code PushUp

😟 Code PushUp report has regressed – compared target commit 54c2491 with source commit 7e6c29d.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Security 🟡 88 🟡 73 ↓ −14.7
Performance 🟡 54 🔴 50 ↓ −3.9
Custom checks 🟡 67 🟡 67 –
Code coverage 🟡 90 🟡 90 –
Updates 🟡 76 🟡 76 –
Accessibility 🟢 91 🟢 91 –
Best Practices 🟢 100 🟢 100 –
SEO 🟡 61 🟡 61 –
Bug prevention 🟢 100 🟢 100 –
Code style 🟢 100 🟢 100 –
👎 2 groups regressed, 👎 6 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JS Packages NPM audit 🟡 88 🟡 73 ↓ −14.7
Lighthouse Performance 🟡 54 🔴 50 ↓ −3.9

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JS Packages Vulnerabilities for NPM dev dependencies. 🟨 22 vulnerabilities (22 low) 🟥 26 vulnerabilities (4 high, 22 low) ↑ +18.2 %
Lighthouse Largest Contentful Paint 🟨 3.0 s 🟨 3.4 s ↑ +14.6 %
JS Packages Vulnerabilities for NPM prod dependencies. 🟩 3 vulnerabilities (3 low) 🟨 4 vulnerabilities (1 high, 3 low) ↑ +33.3 %
Lighthouse Speed Index 🟥 6.8 s 🟥 7.1 s ↑ +5.7 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 3.0 s ↑ +4.3 %
Lighthouse Time to Interactive 🟥 14.6 s 🟥 15.4 s ↑ +5.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 28 resources found ↑ +1.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,820 KiB 🟩 Total size was 1,827 KiB ↑ +0.4 %
Lighthouse Total Blocking Time 🟥 4,740 ms 🟥 6,170 ms ↑ +30.4 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +5.5 %
Lighthouse Minimizes main-thread work 🟥 19.0 s 🟥 18.6 s ↓ −2.3 %
Lighthouse JavaScript execution time 🟥 9.5 s 🟥 9.1 s ↓ −3.6 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 710 ms 🟥 Potential savings of 660 ms ↓ −6.6 %
Lighthouse Server Backend Latencies 🟩 250 ms 🟩 210 ms ↓ −16 %
Lighthouse Network Round Trip Times 🟩 80 ms 🟩 60 ms ↓ −26.2 %
Lighthouse Initial server response time was short 🟩 Root document took 500 ms 🟩 Root document took 480 ms ↓ −4.2 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 72 KiB 🟥 Potential savings of 82 KiB ↑ +3.3 %
Lighthouse Max Potential First Input Delay 🟥 2,740 ms 🟥 2,740 ms ↑ +0.1 %
JS Packages Outdated NPM dev dependencies. 🟨 40 outdated package versions (26 major, 10 minor, 3 patch, 1 prerelease) 🟨 43 outdated package versions (26 major, 13 minor, 4 patch) ↑ +7.5 %
Lighthouse Avoids an excessive DOM size 🟥 2,243 elements 🟥 2,246 elements ↑ +0.1 %
JS Packages Outdated NPM prod dependencies. 🟨 8 outdated package versions (5 major, 1 minor, 2 patch) 🟨 10 outdated package versions (5 major, 1 minor, 4 patch) ↑ +25 %

492 other audits are unchanged.

@github-actions github-actions bot added the 🦾 CI/CD continuous integration and deployment label Nov 9, 2024
@BioPhoton BioPhoton marked this pull request as ready for review November 10, 2024 02:52
@BioPhoton BioPhoton mentioned this pull request Nov 10, 2024
Open
matejchalk
matejchalk requested changes Nov 11, 2024
View reviewed changes
e2e/cli-e2e/tests/collect.e2e.test.ts Show resolved Hide resolved
e2e/plugin-coverage-e2e/vite.config.e2e.ts Show resolved Hide resolved
examples/react-todos-app/code-pushup.config.js Outdated Show resolved Hide resolved
static-environments/coverage-e2e-env/.gitignore Outdated Show resolved Hide resolved
static-environments/coverage-e2e-env/project.json Outdated Show resolved Hide resolved
BioPhoton
BioPhoton commented Nov 18, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
BioPhoton
BioPhoton commented Nov 18, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the 🦾 CI/CD continuous integration and deployment label Nov 18, 2024
matejchalk
matejchalk previously approved these changes Nov 19, 2024
View reviewed changes
e2e/plugin-coverage-e2e/tests/collect.e2e.test.ts Outdated Show resolved Hide resolved
@BioPhoton BioPhoton mentioned this pull request Nov 19, 2024
Open
@BioPhoton BioPhoton merged commit 3fecae9 into main Nov 19, 2024
16 checks passed
@BioPhoton BioPhoton deleted the split-coverage-e2e branch November 19, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejchalk matejchalk matejchalk approved these changes

@vmasek vmasek Awaiting requested review from vmasek

@hanna-skryl hanna-skryl Awaiting requested review from hanna-skryl

Assignees

@BioPhoton BioPhoton

Labels
🔬 testing writing tests 🛠️ tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BioPhoton @matejchalk